cleanup(pubsub): tighten visibility of internal dispatcher components#5633
Open
suzmue wants to merge 1 commit intogoogleapis:mainfrom
Open
cleanup(pubsub): tighten visibility of internal dispatcher components#5633suzmue wants to merge 1 commit intogoogleapis:mainfrom
suzmue wants to merge 1 commit intogoogleapis:mainfrom
Conversation
Tighten visibility from `pub(crate)` to private for internal actor components and helper functions that are exclusively used within `publisher/actor.rs` and `subscriber/handler.rs`. This improves code hygiene by minimizing internal API surface area.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request restricts the visibility of several internal components within the pubsub crate by changing pub(crate) modifiers to private. These changes affect the publisher's actor implementations and the subscriber's acknowledgement handling logic. I have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5633 +/- ##
==========================================
- Coverage 97.76% 97.76% -0.01%
==========================================
Files 220 220
Lines 50961 50957 -4
==========================================
- Hits 49823 49819 -4
Misses 1138 1138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alvarowolfx
approved these changes
May 8, 2026
PhongChuong
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tighten visibility from
pub(crate)to private for internal actor components and helper functions that are exclusively used withinpublisher/actor.rsandsubscriber/handler.rs.